Skip to content

[DPG] PID: add QA for TOF dynamic columns#14883

Merged
vkucera merged 1 commit intomasterfrom
njacazio-patch-4
Apr 7, 2026
Merged

[DPG] PID: add QA for TOF dynamic columns#14883
vkucera merged 1 commit intomasterfrom
njacazio-patch-4

Conversation

@njacazio
Copy link
Copy Markdown
Collaborator

@njacazio njacazio commented Feb 10, 2026

No description provided.

@github-actions github-actions bot added the dpg label Feb 10, 2026
@github-actions github-actions bot changed the title [PID] add QA for TOF dynamic columns [DPG] [PID] add QA for TOF dynamic columns Feb 10, 2026
@njacazio njacazio marked this pull request as ready for review March 11, 2026 09:42
@njacazio njacazio enabled auto-merge (squash) March 11, 2026 09:42
@vkucera vkucera changed the title [DPG] [PID] add QA for TOF dynamic columns [PID] add QA for TOF dynamic columns Mar 12, 2026
@github-actions github-actions bot changed the title [PID] add QA for TOF dynamic columns [Common,DPG] [PID] add QA for TOF dynamic columns Mar 12, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 30, 2026 •
edited
Loading

Error while checking build/O2Physics/o2 for 697f759 at 2026-04-04 09:18:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 30, 2026

@njacazio What is the status?

@njacazio
Copy link
Copy Markdown
Collaborator Author

njacazio commented Mar 30, 2026

@njacazio What is the status?

Ciao @vkucera I think the CI is failing, apart from that it's waiting for review

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 30, 2026

@njacazio What is the status?

Ciao @vkucera I think the CI is failing, apart from that it's waiting for review

I meant the review. The commit is almost 3 weeks old and no one has reviewed it yet.

@njacazio njacazio mentioned this pull request Apr 5, 2026
Merged
@njacazio
[PID] add QA for TOF dynamic columns
a0c744c 
- add more TOF columns getters
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

O2 linter results: ❌ 19 errors, ⚠️ 48 warnings, 🔕 0 disabled

@njacazio njacazio disabled auto-merge April 7, 2026 11:02
@njacazio njacazio enabled auto-merge (squash) April 7, 2026 11:02
alibuild
alibuild approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio changed the title [Common,DPG] [PID] add QA for TOF dynamic columns [DPG] PID: add QA for TOF dynamic columns Apr 7, 2026
@vkucera vkucera disabled auto-merge April 7, 2026 11:08
@vkucera vkucera enabled auto-merge (squash) April 7, 2026 11:08
@vkucera vkucera merged commit 0a42bb2 into master Apr 7, 2026
14 of 18 checks passed
@vkucera vkucera deleted the njacazio-patch-4 branch April 7, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo

@iarsene iarsene Awaiting requested review from iarsene

@ktf ktf Awaiting requested review from ktf

@ddobrigk ddobrigk Awaiting requested review from ddobrigk

@dsekihat dsekihat Awaiting requested review from dsekihat

Assignees

No one assigned

Labels

dpg

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njacazio @alibuild @vkucera